New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editing PATH in macOS build instructions #2379

Merged

fig02 merged 2 commits into zeldaret:main from cadmic:fix-path

Dec 21, 2024

Contributor

cadmic commented Dec 17, 2024 •

edited

Loading

Problems pointed out by Aroenai on Discord:

$PATH was expanded in the command, so the current value of the path is written instead of literally $PATH
The correct config file for zsh is .zprofile, not .zsh_profile

cadmic added 2 commits

December 17, 2024 12:03


          Fix editing PATH in macOS build instructions

070da64


          Need quotes for paths with spaces

8688c8d

fig02 approved these changes

View reviewed changes

fig02 added the Needs second approval label

fig02 merged commit 970639b into zeldaret:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs second approval